have a valid hyperlink in all error messages#2415
Closed
olivroy wants to merge 5 commits intor-lib:mainfrom
olivroy:pkgdown.ymllink
Closed
have a valid hyperlink in all error messages#2415olivroy wants to merge 5 commits intor-lib:mainfrom olivroy:pkgdown.ymllink
olivroy wants to merge 5 commits intor-lib:mainfrom
olivroy:pkgdown.ymllink
Conversation
Member
|
Yeah, I agree that recommending folks call |
Collaborator
Author
|
Opened #2419 instead! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #2403
You can see that some hyperlinks in errors will not work if your pkgdown config is pkgdown/_pkgdown.yml.
to test this interactively
I also decided to remove the pkgdown_config_href() function I introduced to use the same approach everywhere.
To avoid problems in tests when testing low level functions (when pkg doesn't exist), I added a fallback to pkgdown_config_relpath()
The solution is a bit ugly. But I couldn't see a better way to track pkg otherwise.
Maybe a better way would be to add a bullet that suggests
{.run usethis::edit_pkgdown_config()}to solve this?to avoid this
